Skip to content

tools: enable linter in test/fixtures/errors #57701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 4 commits into from
Apr 4, 2025
Merged

tools: enable linter in test/fixtures/errors #57701

aduh95 merged 4 commits into from
Apr 4, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 1, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 1, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (633ba00) to head (9e81b22).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57701   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files         630      630           
  Lines      184990   184990           
  Branches    36214    36220    +6     
=======================================
+ Hits       166948   166957    +9     
+ Misses      11001    10997    -4     
+ Partials     7041     7036    -5

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jakecastelli
Copy link
Member

jakecastelli commented Apr 4, 2025

Just for the educational purpose - would this commit [Merge branch 'main' into lint-errors-output] cause issue to land?

@aduh95
Copy link
Contributor Author

aduh95 commented Apr 4, 2025

would this commit [Merge branch 'main' into lint-errors-output] cause issue to land?

Yes definitely, it can only work if the PR is landed manually – which we have to do anyway because CQ refuses to land PR that touch test files without a full CI re-run, as it can't tell the changes are purely cosmetic.

@aduh95 aduh95 merged commit caf478b into nodejs:main Apr 4, 2025
20 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 4, 2025

Landed in caf478b

@aduh95 aduh95 deleted the lint-errors-output branch April 4, 2025 13:41
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@aduh95 @JonasBa
tools: enable linter in test/fixtures/errors
375516d 
PR-URL: nodejs#57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
1c0b900 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
b9043c9 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
tools: enable linter in test/fixtures/errors
9400160 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
e0e4251 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/errors
f245bfe 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/errors
5c24124 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
tools: enable linter in test/fixtures/errors
80d58c3 
PR-URL: #57701
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @jakecastelli @MoLow @nodejs-github-bot